Conversation
Contributor
nroi
commented
Sep 16, 2025
nroi
commented
- chore: add terraform-provider-meshstack to .gitignore
- feat: support meshLandingZones
nroi
force-pushed
the
feature/CU-86c57xgjy_Support-for-Landing-Zones-in-meshStack-Terraform-Provider
branch
16 times, most recently
from
97f95b3 to
a4dec3a
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for landing zones in the meshStack Terraform provider by introducing comprehensive CRUD operations for managing landing zones across multiple cloud platforms. The implementation follows the existing provider patterns and provides both resource and data source capabilities.
- Adds new
meshstack_landingzoneresource and data source with full CRUD support - Implements platform-specific configurations for AWS, Azure, GCP, Kubernetes, OpenShift, and AKS
- Includes comprehensive documentation and example configurations
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/provider/provider.go | Registers new landing zone resource and data source with the provider |
| internal/provider/landingzone_resource.go | Implements the landing zone resource with complex platform-specific schema definitions |
| internal/provider/landingzone_data_source.go | Implements the landing zone data source for reading existing landing zones |
| client/landingzone.go | Adds HTTP client methods for landing zone CRUD operations |
| client/client.go | Adds landing zone endpoint configuration to the client |
| client/*.go | Defines platform-specific property structs for different cloud platforms |
| examples/ | Provides usage examples for both resource and data source |
| docs/ | Auto-generated documentation for the new landing zone functionality |
Comments suppressed due to low confidence (2)
internal/provider/landingzone_data_source.go:1
- The platform type field is marked as Required in a data source schema, but data sources should only have Computed fields for output values. This should be Computed: true instead of Required: true.
package provider
internal/provider/landingzone_data_source.go:1
- The platform_ref attribute is missing from the data source schema definition, but it's referenced in the documentation. This will cause the data source to fail when trying to read landing zones that have platform references.
package provider
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nroi
force-pushed
the
feature/CU-86c57xgjy_Support-for-Landing-Zones-in-meshStack-Terraform-Provider
branch
2 times, most recently
from
14795a0 to
d8aae3a
Compare
henryde
requested changes
Sep 19, 2025
CU-86c57xgjy
nroi
force-pushed
the
feature/CU-86c57xgjy_Support-for-Landing-Zones-in-meshStack-Terraform-Provider
branch
from
d8aae3a to
8767363
Compare
henryde
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.